Skip to content

feat: team feature domain and github#2424

Merged
mindlesscloud merged 7 commits into
apache:mainfrom
merico-ai:implement-team
Jul 6, 2022
Merged

feat: team feature domain and github#2424
mindlesscloud merged 7 commits into
apache:mainfrom
merico-ai:implement-team

Conversation

@abeizn
Copy link
Copy Markdown
Contributor

@abeizn abeizn commented Jul 6, 2022

Summary

update github and gitee users to accounts.

Does this close any open issues?

closed #2427
closed #2431

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@abeizn abeizn changed the title Implement team feat: team feature domain and github Jul 6, 2022
Copy link
Copy Markdown
Contributor

@mindlesscloud mindlesscloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mindlesscloud mindlesscloud merged commit 967658d into apache:main Jul 6, 2022
&archived.GithubIssueEvent{},
&archived.GithubIssueLabel{},
&archived.GithubUser{},
&archived.GithubAccount{},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. it should not change existing migration scripts.

Copy link
Copy Markdown
Contributor

@likyh likyh Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or change the version for it at least. And it should drop the old table GithubUser here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][Team] domain layer team feature [Feature][Team] update github user to account

3 participants